Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the test code so that it does not
import
from the/functions/src/
package, and keeps all/tests/integration/
code in the maple package. This is to avoid the magic importing the firebase team is doing to support v1 functions not working in the tests when upgrading thefirebase-functions
package to support node20 for #1698Checklist
Screenshots
N/A
Known issues
The integration tests will fail until they have been cut over to avoid cross-package imports. These will be fixed in stages during this draft PR
Steps to test/reproduce
For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:
yarn test:integration-ci
expecting all tests to pass (if they are not skipped)