Skip to content

⚡️ Speed up method S3DataSource.delete_object_tagging by 47% #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method S3DataSource.delete_object_tagging by 47% #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions backend/python/app/sources/external/s3/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,12 @@ def __init__(self, s3_client: S3Client) -> None:
self._s3_client = s3_client
self._session = None

async def _get_aioboto3_session(self) -> aioboto3.Session: # type: ignore[valid-type]
async def _get_aioboto3_session(self) -> aioboto3.Session:
"""Get or create the aioboto3 session."""
if self._session is None:
# Option 1: Get the existing session directly from S3Client (recommended)
self._session = self._s3_client.get_session()
# S3Client.get_session is synchronous, so run it in a thread
self._session = await asyncio.to_thread(self._s3_client.get_session)

# Option 2: Create new session from credentials (if needed)
# credentials = self._s3_client.get_credentials()
Expand Down Expand Up @@ -964,8 +965,9 @@ async def delete_object_tagging(self,

try:
session = await self._get_aioboto3_session()
# Use a single async context for client creation/execution for memory efficiency
async with session.client('s3') as s3_client:
response = await getattr(s3_client, 'delete_object_tagging')(**kwargs)
response = await s3_client.delete_object_tagging(**kwargs)
return self._handle_s3_response(response)
except ClientError as e:
error_code = e.response.get('Error', {}).get('Code', 'Unknown')
Expand Down