⚡️ Speed up function _is_viewable_list by 31%
#15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 31% (0.31x) speedup for
_is_viewable_listinpanel/viewable.py⏱️ Runtime :
74.6 microseconds→57.1 microseconds(best of17runs)📝 Explanation and details
Optimizations made:
type(item_type) is tupleinstead ofisinstancefor a faster type check.param_list.item_typeto a local variable to avoid repeated attribute lookup.all()with an explicit for-loop, which is faster due to avoiding the overhead of a generator and function call.✅ Correctness verification report:
🌀 Generated Regression Tests and Runtime
To edit these changes
git checkout codeflash/optimize-_is_viewable_list-mha0zhphand push.