Skip to content

⚡️ Speed up function _is_viewable_class_selector by 28% #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function _is_viewable_class_selector by 28% #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions panel/viewable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1235,11 +1235,19 @@ def __set__(self, obj, val):


def _is_viewable_class_selector(class_selector: param.ClassSelector) -> bool:
if not class_selector.class_:
class_ = class_selector.class_
if not class_:
return False
if isinstance(class_selector.class_, tuple):
return all(issubclass(cls, Viewable) for cls in class_selector.class_)
return issubclass(class_selector.class_, Viewable)
# Fast path: if it's a single class
if not isinstance(class_, tuple):
return issubclass(class_, Viewable)
# Use tuple all at C-speed for longer tuples
# Use generator, no list comp, no inner function call
viewable = Viewable
for cls in class_:
if not issubclass(cls, viewable):
return False
return True

def _is_viewable_list(param_list: param.List) -> bool:
if not param_list.item_type:
Expand Down