Skip to content

⚡️ Speed up method MimeRenderMixin._on_error by 23% #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method MimeRenderMixin._on_error by 23% #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions panel/viewable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,15 +502,27 @@ def _on_msg(self, ref: str, manager, msg) -> None:
doc.hold(held)

def _on_error(self, ref: str, error: Exception) -> None:
if ref not in state._handles or config.console_output in [None, 'disable']:
# Fast-path exit for ref not in handles or console_output is off/disabled
if ref not in state._handles:
return
console_output = config.console_output
if console_output is None or console_output == 'disable':
return

handle, accumulator = state._handles[ref]
formatted = '\n<pre>'+escape(traceback.format_exc())+'</pre>\n'
if config.console_output == 'accumulate':
# Avoid string concatenation, use f-string for slightly better performance and readability
formatted = f'\n<pre>{escape(traceback.format_exc())}</pre>\n'

if console_output == 'accumulate':
accumulator.append(formatted)
elif config.console_output == 'replace':
elif console_output == 'replace':
accumulator[:] = [formatted]

# Fast bool check for non-empty accumulator
if accumulator:
# Avoid repeated '\n'.join if possible:
# (join is fast for small lists, but accumulator is potentially unbounded;
# can't optimize further unless we change external behavior.)
handle.update({'text/html': '\n'.join(accumulator)}, raw=True)

def _on_stdout(self, ref: str, stdout: Any) -> None:
Expand Down