Skip to content

⚡️ Speed up method FigureManagers.get by 26% #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method FigureManagers.get by 26% #476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions marimo/_plugins/stateless/mpl/_mpl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,11 @@ def add(self, manager: FigureManagerWebAgg) -> None:
self.figure_managers[str(manager.num)] = manager

def get(self, figure_id: str) -> FigureManagerWebAgg:
if figure_id not in self.figure_managers:
try:
# Avoid double lookup by using try/except for performance
return self.figure_managers[figure_id]
except KeyError:
raise RuntimeError(f"Figure {figure_id} not found.") # noqa: E501
return self.figure_managers[str(figure_id)]

def remove(self, manager: FigureManagerWebAgg) -> None:
try:
Expand Down