Skip to content

⚡️ Speed up function _has_script_tag_without_src by 17% #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function _has_script_tag_without_src by 17% #470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions marimo/_output/formatters/iframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,14 @@ def maybe_wrap_in_iframe(html_content: str) -> str:

def _has_script_tag_without_src(html_content: str) -> bool:
# Cheap check
if "<script" not in html_content:
idx = html_content.find("<script")
if idx == -1:
return False

# Fast path: scan only relevant substring from first <script
parser = ScriptTagParser()
try:
parser.feed(html_content) # type: ignore
parser.feed(html_content[idx:]) # type: ignore
return parser.has_script_without_src
except StopIteration:
return parser.has_script_without_src
Expand Down