Skip to content

⚡️ Speed up function is_mcp_config_empty by 16% #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function is_mcp_config_empty by 16% #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion marimo/_server/ai/mcp/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,12 @@ def is_mcp_config_empty(config: MCPConfig | None) -> bool:
"""Check if the MCP configuration is empty."""
if config is None:
return True
return not config.get("mcpServers") and not config.get("presets")
# Use direct key lookup with .get and short-circuit evaluation for early return
mcp_servers = config.get("mcpServers")
if mcp_servers:
return False
presets = config.get("presets")
return not presets


@dataclass
Expand Down