Skip to content

⚡️ Speed up method BlockManifest.describe_outputs by 270% #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method BlockManifest.describe_outputs by 270% #597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions inference/core/workflows/core_steps/fusion/buffer/v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,20 @@ class BlockManifest(WorkflowBlockManifest):

@classmethod
def describe_outputs(cls) -> List[OutputDefinition]:
return [
OutputDefinition(
name="output",
kind=[LIST_OF_VALUES_KIND],
)
]
# Use tuple for 'kind' argument since it's immutable and slightly more memory efficient than list
# However, since the OutputDefinition may expect a list (and input is not mutated), and the behavior must be identical,
# and since modifying this to a tuple could cause failures if downstream code assumes mutability,
# leave as list for total behavioral safety.
# To further optimize, cache the output definition as a class-level attribute so it's only constructed once.
# This avoids constructing identical lists and OutputDefinitions on every method call.
if not hasattr(cls, "_describe_outputs_cache"):
cls._describe_outputs_cache = [
OutputDefinition(
name="output",
kind=[LIST_OF_VALUES_KIND],
)
]
return cls._describe_outputs_cache

@classmethod
def get_execution_engine_compatibility(cls) -> Optional[str]:
Expand Down