Skip to content

⚡️ Speed up method MicrosoftSQLServerSinkBlockV1._validate_data by 27% #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method MicrosoftSQLServerSinkBlockV1._validate_data by 27% #582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions inference/enterprise/workflows/enterprise_blocks/sinks/microsoft_sql_server/v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,9 +405,9 @@ def _validate_data(
raise ValueError("All items in data list must be dictionaries")

if len(data) > 1:
first_keys = set(data[0].keys())
first_keys = data[0].keys()
for idx, item in enumerate(data[1:], 1):
if set(item.keys()) != first_keys:
if item.keys() != first_keys:
raise ValueError(
f"Dictionary at index {idx} has different keys than the first dictionary"
)
Expand Down