Skip to content

⚡️ Speed up method HaloVisualizationBlockV1.getAnnotator by 9% #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method HaloVisualizationBlockV1.getAnnotator by 9% #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions inference/core/workflows/core_steps/visualizations/common/base_colorable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,24 @@
)
from inference.core.workflows.prototypes.block import BlockResult

_MPL_PALETTES_R = {
"Greys_R",
"Purples_R",
"Blues_R",
"Greens_R",
"Oranges_R",
"Reds_R",
"Wistia",
"Pastel1",
"Pastel2",
"Paired",
"Accent",
"Dark2",
"Set1",
"Set2",
"Set3",
}


class ColorableVisualizationManifest(PredictionsVisualizationManifest, ABC):
color_palette: Union[
Expand Down Expand Up @@ -124,23 +142,7 @@ def getPalette(self, color_palette, palette_size, custom_colors):
else:
palette_name = color_palette.replace("Matplotlib ", "")

if palette_name in [
"Greys_R",
"Purples_R",
"Blues_R",
"Greens_R",
"Oranges_R",
"Reds_R",
"Wistia",
"Pastel1",
"Pastel2",
"Paired",
"Accent",
"Dark2",
"Set1",
"Set2",
"Set3",
]:
if palette_name in _MPL_PALETTES_R:
palette_name = palette_name.capitalize()
else:
palette_name = palette_name.lower()
Expand Down
17 changes: 6 additions & 11 deletions inference/core/workflows/core_steps/visualizations/halo/v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,17 +103,12 @@ def getAnnotator(
opacity: float,
kernel_size: int,
) -> sv.annotators.base.BaseAnnotator:
key = "_".join(
map(
str,
[
color_palette,
palette_size,
color_axis,
opacity,
kernel_size,
],
)
key = (
color_palette,
palette_size,
color_axis,
opacity,
kernel_size,
)

if key not in self.annotatorCache:
Expand Down