Skip to content

Adding type hints to the dummy code for verify-setup (CF-647) #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

Adding type hints to the dummy code for verify-setup (CF-647) #234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6db214d
adding type hints so that tests generated are sane
aseembits93 May 20, 2025
a7c1e45
Merge branch 'main' into check-verify-setup
aseembits93 May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions codeflash/cli_cmds/cmd_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def collect_setup_info() -> SetupInfo:
else:
apologize_and_exit()
else:
tests_root = Path(curdir) / Path(cast(str, tests_root_answer))
tests_root = Path(curdir) / Path(cast("str", tests_root_answer))
tests_root = tests_root.relative_to(curdir)
ph("cli-tests-root-provided")

Expand Down Expand Up @@ -302,7 +302,7 @@ def collect_setup_info() -> SetupInfo:
elif benchmarks_answer == no_benchmarks_option:
benchmarks_root = None
else:
benchmarks_root = tests_root / Path(cast(str, benchmarks_answer))
benchmarks_root = tests_root / Path(cast("str", benchmarks_answer))

# TODO: Implement other benchmark framework options
# if benchmarks_root:
Expand Down Expand Up @@ -354,9 +354,9 @@ def collect_setup_info() -> SetupInfo:
module_root=str(module_root),
tests_root=str(tests_root),
benchmarks_root=str(benchmarks_root) if benchmarks_root else None,
test_framework=cast(str, test_framework),
test_framework=cast("str", test_framework),
ignore_paths=ignore_paths,
formatter=cast(str, formatter),
formatter=cast("str", formatter),
git_remote=str(git_remote),
)

Expand Down Expand Up @@ -466,7 +466,7 @@ def check_for_toml_or_setup_file() -> str | None:
click.echo("⏩️ Skipping pyproject.toml creation.")
apologize_and_exit()
click.echo()
return cast(str, project_name)
return cast("str", project_name)


def install_github_actions(override_formatter_check: bool = False) -> None:
Expand Down Expand Up @@ -852,7 +852,7 @@ def enter_api_key_and_save_to_rc() -> None:


def create_bubble_sort_file_and_test(args: Namespace) -> tuple[str, str]:
bubble_sort_content = """def sorter(arr):
bubble_sort_content = """def sorter(arr: list[int] | list[float]) -> list[int] | list[float]:
for i in range(len(arr)):
for j in range(len(arr) - 1):
if arr[j] > arr[j + 1]:
Expand Down
Loading