-
Notifications
You must be signed in to change notification settings - Fork 22
Python 'range' objects can be compared with double equal #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
@aseembits93 I think the PR reviewer is right, we should exercise scenarios like empty ranges, negative steps, or non-unit steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR Type
Enhancement, Tests
Description
Support range object comparisons.
Add tests for range comparisons.
Changes walkthrough 📝
comparator.py
Add range support in comparatorcodeflash/verification/comparator.py
rangeto simple types tuplerangeusing==test_comparator.py
Add tests for range comparisonstests/test_comparator.py
rangeobjectsranges