Skip to content

Roboflow fixes #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

Roboflow fixes #190

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f44f620
accessing name attributes causes another error whcih propagates up
KRRT7 May 8, 2025
d0d0b77
Merge branch 'main' into rbfl-fix
KRRT7 May 9, 2025
e110f1a
Merge branch 'main' into rbfl-fix
KRRT7 May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions codeflash/context/code_context_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,9 @@ def extract_code_string_context_from_files(
continue
try:
qualified_helper_function_names = {func.qualified_name for func in helper_function_sources}
code_without_unused_defs = remove_unused_definitions_by_function_names(original_code, qualified_helper_function_names)
code_without_unused_defs = remove_unused_definitions_by_function_names(
original_code, qualified_helper_function_names
)
code_context = parse_code_and_prune_cst(
code_without_unused_defs, code_context_type, set(), qualified_helper_function_names, remove_docstrings
)
Expand Down Expand Up @@ -325,7 +327,9 @@ def extract_code_markdown_context_from_files(
continue
try:
qualified_helper_function_names = {func.qualified_name for func in helper_function_sources}
code_without_unused_defs = remove_unused_definitions_by_function_names(original_code, qualified_helper_function_names)
code_without_unused_defs = remove_unused_definitions_by_function_names(
original_code, qualified_helper_function_names
)
code_context = parse_code_and_prune_cst(
code_without_unused_defs, code_context_type, set(), qualified_helper_function_names, remove_docstrings
)
Expand Down Expand Up @@ -403,12 +407,8 @@ def get_function_sources_from_jedi(
for name in names:
try:
definitions: list[Name] = name.goto(follow_imports=True, follow_builtin_imports=False)
except Exception as e:
try:
logger.exception(f"Error while getting definition for {name.full_name}: {e}")
except Exception as e:
# name.full_name can also throw exceptions sometimes
logger.exception(f"Error while getting definition: {e}")
except Exception: # noqa: BLE001
logger.debug(f"Error while getting definitions for {qualified_function_name}")
definitions = []
if definitions:
# TODO: there can be multiple definitions, see how to handle such cases
Expand All @@ -424,7 +424,12 @@ def get_function_sources_from_jedi(
and not belongs_to_function_qualified(definition, qualified_function_name)
and definition.full_name.startswith(definition.module_name)
# Avoid nested functions or classes. Only class.function is allowed
and len((qualified_name := get_qualified_name(definition.module_name, definition.full_name)).split(".")) <= 2
and len(
(qualified_name := get_qualified_name(definition.module_name, definition.full_name)).split(
"."
)
)
<= 2
):
function_source = FunctionSource(
file_path=definition_path,
Expand Down
Loading