Skip to content

Conversation

@KRRT7
Copy link
Contributor

@KRRT7 KRRT7 commented Apr 16, 2025

PR Type

Enhancement


Description

  • Loosen pytest version constraint

  • Exclude problematic pytest 8.3.4

  • Simplify CI Python version matrix


Changes walkthrough 📝

Relevant files
Configuration changes
unit-tests.yaml
Simplify CI Python version specs                                                 

.github/workflows/unit-tests.yaml

  • Use major Python versions instead of patches
  • Remove Python 3.13 from CI matrix
  • +1/-1     
    Dependencies
    pyproject.toml
    Loosen pytest dependency constraint                                           

    pyproject.toml

  • Replace upper pytest bound with exclusion
  • Allow all pytest versions except 8.3.4
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link

    github-actions bot commented Apr 16, 2025

    PR Reviewer Guide 🔍

    (Review updated until commit 3649e9b)

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Missing Python version

    The test matrix now only includes Python 3.9–3.12, omitting 3.13. Consider adding 3.13 to ensure coverage.

    python-version: ["3.9", "3.10", "3.11", "3.12"]
    Loose version constraint

    The new pytest constraint allows all future versions except 8.3.4, which may introduce breaking changes. Consider adding an upper bound for compatibility.

    pytest = ">=7.0.0,!=8.3.4"

    @github-actions
    Copy link

    github-actions bot commented Apr 16, 2025

    PR Code Suggestions ✨

    Latest suggestions up to 3649e9b
    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Include latest supported Python

    Re-add Python 3.13 to the testing matrix to ensure coverage of the latest supported
    version.

    .github/workflows/unit-tests.yaml [14]

    -python-version: ["3.9", "3.10", "3.11", "3.12"]
    +python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
    Suggestion importance[1-10]: 7

    __

    Why: Re-adding Python 3.13 ensures the CI matrix covers the latest supported version, maintaining compatibility and test coverage.

    Medium
    Possible issue
    Restrict pytest upper bound

    Restrict pytest to versions below 8.3.4 instead of excluding only 8.3.4 to prevent
    installing untested future major versions.

    pyproject.toml [72]

    -pytest = ">=7.0.0,!=8.3.4"
    +pytest = ">=7.0.0,<8.3.4"
    Suggestion importance[1-10]: 6

    __

    Why: Restoring the <8.3.4 upper bound prevents installing untested future major pytest releases and avoids compatibility issues.

    Low

    Previous suggestions

    Suggestions
    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Include Python 3.13 tests

    Re-add testing for Python 3.13 to ensure coverage of the latest minor version.

    .github/workflows/unit-tests.yaml [14]

    -python-version: ["3.9", "3.10", "3.11", "3.12"]
    +python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
    Suggestion importance[1-10]: 7

    __

    Why: Adding Python 3.13 ensures the CI matrix covers the latest minor release and prevents missing compatibility issues.

    Medium
    General
    Add upper bound to pytest dependency

    Constrain pytest with an upper bound (e.g. <9.0.0) to prevent untested major releases.

    pyproject.toml [72]

    -pytest = ">=7.0.0,!=8.3.4"
    +pytest = ">=7.0.0,!=8.3.4,<9.0.0"
    Suggestion importance[1-10]: 6

    __

    Why: Constraining pytest to <9.0.0 guards against potential breaking changes in a future major release while allowing fixes and minor updates.

    Low

    @github-actions github-actions bot added the workflow-modified This PR modifies GitHub Actions workflows label Apr 16, 2025
    @KRRT7 KRRT7 closed this Apr 21, 2025
    @KRRT7 KRRT7 force-pushed the pytest-looseing branch from b918a0a to d4dd33b Compare April 21, 2025 11:03
     # 3.13 is causing a strange string formatting error, won't spend more time on it until neccesary.
    @KRRT7 KRRT7 reopened this Apr 21, 2025
    @github-actions
    Copy link

    Persistent review updated to latest commit 3649e9b

    @github-actions
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Include Python 3.13 tests

    Re-add testing for Python 3.13 to ensure coverage of the latest minor version.

    .github/workflows/unit-tests.yaml [14]

    -python-version: ["3.9", "3.10", "3.11", "3.12"]
    +python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
    Suggestion importance[1-10]: 7

    __

    Why: Adding Python 3.13 ensures the CI matrix covers the latest minor release and prevents missing compatibility issues.

    Medium
    General
    Add upper bound to pytest dependency

    Constrain pytest with an upper bound (e.g. <9.0.0) to prevent untested major releases.

    pyproject.toml [72]

    -pytest = ">=7.0.0,!=8.3.4"
    +pytest = ">=7.0.0,!=8.3.4,<9.0.0"
    Suggestion importance[1-10]: 6

    __

    Why: Constraining pytest to <9.0.0 guards against potential breaking changes in a future major release while allowing fixes and minor updates.

    Low

    @KRRT7 KRRT7 marked this pull request as ready for review April 21, 2025 11:10
    @github-actions
    Copy link

    Persistent review updated to latest commit 3649e9b

    @misrasaurabh1 misrasaurabh1 self-requested a review April 21, 2025 17:26
    @KRRT7 KRRT7 enabled auto-merge April 21, 2025 20:15
    @misrasaurabh1 misrasaurabh1 disabled auto-merge April 21, 2025 23:40
    @misrasaurabh1 misrasaurabh1 merged commit ca9f2d8 into main Apr 21, 2025
    16 checks passed
    @KRRT7 KRRT7 deleted the pytest-looseing branch April 22, 2025 02:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Review effort 2/5 workflow-modified This PR modifies GitHub Actions workflows

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants