Skip to content

⚡️ Speed up function magma by 13% #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up function magma by 13% #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/bokeh/palettes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,13 +412,6 @@

import logging # isort:skip
log = logging.getLogger(__name__)

#-----------------------------------------------------------------------------
# Imports
#-----------------------------------------------------------------------------

# Standard library imports
import math
from copy import deepcopy
from typing import TYPE_CHECKING, TypeAlias

Expand Down Expand Up @@ -1526,7 +1519,14 @@ def linear_palette(palette: Palette, n: int) -> Palette:
"""
if n > len(palette):
raise ValueError(f"Requested {n} colors, function can only return colors up to the base palette's length ({len(palette)})")
return tuple( palette[math.floor(i)] for i in np.linspace(0, len(palette)-1, num=n) )
# Optimization: Avoid using math.floor (which is slow for every value), and tuple comprehension over floats.
# Instead, precompute all indices as ints and index palette directly.
# np.linspace returns float, but we want nearest lower integer index for each position.
indices = np.linspace(0, len(palette)-1, num=n)
# Use astype with np.floor for batch integer conversion.
int_indices = indices.astype(int)
# Directly build tuple using list comprehension.
return tuple(palette[i] for i in int_indices)

def diverging_palette(palette1: Palette, palette2: Palette, n: int, midpoint: float = 0.5) -> Palette:
""" Generate a new palette by combining exactly two input palettes.
Expand Down