Skip to content

⚡️ Speed up function _ext_use_mathjax by 9,805% #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up function _ext_use_mathjax by 9,805% #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/bokeh/embed/bundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
from __future__ import annotations

import logging # isort:skip
from bokeh.core.has_props import HasProps

log = logging.getLogger(__name__)

#-----------------------------------------------------------------------------
Expand Down Expand Up @@ -217,7 +219,19 @@ def bundle_for_objs_and_resources(objs: Sequence[HasProps | Document] | None, re

def _query_extensions(all_objs: set[HasProps], query: Callable[[type[HasProps]], bool]) -> bool:
names: set[str] = set()
# Cache models by their top-level module for faster lookup
# Build module-prefix=>model-list only once for performance
if not hasattr(_query_extensions, "_module_models_map"):
module_models_map: dict[str, list[type[HasProps]]] = {}
for model in HasProps.model_class_reverse_map.values():
module_name = model.__module__
top_module = module_name.split(".", 1)[0]
module_models_map.setdefault(top_module, []).append(model)
_query_extensions._module_models_map = module_models_map
else:
module_models_map = _query_extensions._module_models_map

# Only process unique top-level modules from all_objs
for obj in all_objs:
if hasattr(obj, "__implementation__"):
continue
Expand All @@ -228,8 +242,10 @@ def _query_extensions(all_objs: set[HasProps], query: Callable[[type[HasProps]],
continue
names.add(name)

for model in HasProps.model_class_reverse_map.values():
if model.__module__.startswith(name):
# Directly iterate relevant module's models only
models = module_models_map.get(name)
if models:
for model in models:
if query(model):
return True

Expand Down