Skip to content

⚡️ Speed up function _is_visual by 6% #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up function _is_visual by 6% #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/bokeh/plotting/_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,14 @@
#-----------------------------------------------------------------------------
from __future__ import annotations

from bokeh.core.property.dataspec import ColorSpec
from bokeh.models import ColumnarDataSource, ColumnDataSource, GlyphRenderer
from bokeh.models.glyph import Glyph
from bokeh.models.plots import Plot
from bokeh.plotting._legends import pop_legend_kwarg, update_legend

import logging # isort:skip

log = logging.getLogger(__name__)

#-----------------------------------------------------------------------------
Expand All @@ -34,6 +41,8 @@
from ..models.glyph import Glyph
from ..models.plots import Plot

_VISUAL_FEATURES = {'line', 'fill', 'hatch', 'text', 'global'}

#-----------------------------------------------------------------------------
# Globals and constants
#-----------------------------------------------------------------------------
Expand Down Expand Up @@ -314,8 +323,15 @@ def _split_feature_trait(ft: str) -> tuple[str, str | None]:

def _is_visual(ft: str) -> bool:
"""Whether a feature trait name is visual"""
feature, trait = _split_feature_trait(ft)
return feature in ('line', 'fill', 'hatch', 'text', 'global') and trait is not None
# Inline parsing for faster execution, avoiding extra call
idx = ft.find("_")
if idx == -1:
feature = ft[0]
trait = None
else:
feature = ft[:idx]
trait = ft[idx+1:]
return feature in _VISUAL_FEATURES and trait is not None

_GLYPH_SOURCE_MSG = """

Expand Down