Skip to content

⚡️ Speed up function _split_feature_trait by 19% #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up function _split_feature_trait by 19% #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/bokeh/plotting/_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,10 @@ def _process_sequence_literals(glyphclass: type[Glyph], kwargs: Attrs, source: C

def _split_feature_trait(ft: str) -> tuple[str, str | None]:
"""Feature is up to first '_'. Ex. 'line_color' => ['line', 'color']"""
parts = ft.split("_", 1)
return tuple(parts) if len(parts) == 2 else (ft[0], None)
idx = ft.find("_")
if idx == -1:
return (ft[0], None)
return (ft[:idx], ft[idx+1:])

def _is_visual(ft: str) -> bool:
"""Whether a feature trait name is visual"""
Expand Down