Export defaultFormattingOptions.
#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No point having a default when the user cannot access to override it! This was forgotten in PR codedownio#22 when extracting it from PR codedownio#17.
nh2
added a commit
to nh2/solga
that referenced
this pull request
Oct 4, 2021
…ixes. Our fixes: codedownio/aeson-typescript#17 The one that wasn't taken verbatim, which this commit adapts to: Upstremed in: codedownio/aeson-typescript#22 We still have to use our fork to fix `defaultFormattingOptions` not being exported: codedownio/aeson-typescript#27
|
Ah good point haha. Now that I look at it I wish I hadn't exported the actual |
|
@thomasjm I think exporting is always the right thing to do. If it's internal and has no API guarantees, put it into an |
|
I mean I wish I had followed the pattern of exporting the default options only and not the constructor itself, like this. It's a great pattern for being able to extend the options without causing breaking changes and AFAIK it has no downsides. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No point having a default when the user cannot access to override it! Without this, you cannot write code like
This was forgotten in PR #22 when extracting it from PR #17.
Similar to PR #23.
CC @bitonic