Allow configurability of the FIXME strings #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pbrisbin Do custom supplied strings get added to the current strings, or do they replace them? |
|
The code as it is implements replacement. |
|
@pbrisbin Do you think that's obvious as a consumer of this engine? Could we use a better name to communicate that? Or do we rely on documentation? |
|
I (slightly) prefer documentation. If you can think of a better name for the config key, I'm all ears though. |
|
@pbrisbin Ok. With an adjustment to the docs that says "Note: configuration here replaces strings" or whatever, I'm a +1 on this. |
Defaulting to `include_paths: [./]` means it's possible to run
docker run -v $PWD:/code $image
to see raw output from running this engine, which is useful while
developing.
|
Ready for another look. |
pbrisbin
added a commit
that referenced
this pull request
Jan 13, 2016
Allow configurability of the FIXME strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the
README.mddiff for details.Also drops
exclude_pathssupport and defaultsinclude_pathsto["./"]when unspecified (for easier development).
/cc @codeclimate/review @mrb