Update Rubocop config to match CC styleguide #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblandin
force-pushed
the
devon/update-rubocop-config-to-match-styleguide
branch
from
f524a5a to
0712a4b
Compare
|
|
||
| Style/BlockDelimiters: | ||
| Exclude: | ||
| - spec/**/* |
There was a problem hiding this comment.
We probably don't need these since we have the top level .codeclimate.yml spec excludes right?
There was a problem hiding this comment.
I just moved the spec/ exclude path to be duplication engine specific so we should keep these here for the rubocop engine.
There was a problem hiding this comment.
ah okay. Did you move it to take advantage of allowing fixme to analyze spec directory?
There was a problem hiding this comment.
Not fixme specifically. I think there's often an acceptable level of duplication in spec files but thought it best to allow other engines, like rubocop and fixme, to scan that directory.
dblandin
force-pushed
the
devon/update-rubocop-config-to-match-styleguide
branch
2 times, most recently
from
de8c15c to
36f24e7
Compare
| enabled: true | ||
| config: | ||
| languages: | ||
| - ruby |
A small update to bring our rubocop config up-to-date with our styleguide. Following the refactor in #16, few changes in the codebase were needed.
dblandin
force-pushed
the
devon/update-rubocop-config-to-match-styleguide
branch
from
36f24e7 to
77ed4af
Compare
|
Couple of nits, but LGTM! |
dblandin
added a commit
that referenced
this pull request
Feb 12, 2016
…o-match-styleguide Update Rubocop config to match CC styleguide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small update to bring our rubocop config up-to-date with our styleguide.
Following the refactor in #16, few changes in the codebase were needed.
@codeclimate/review 🔎