REST: Changed "endpoint" to optional #3404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REST API methods can be called with absolute URL ("https://") and therefore the property "endpoint" doesn't need to be specified in general
Contributor
Author
|
It looks like the failed test sometimes passes and sometimes fails (tested even in my local environment). |
kobenguyent
approved these changes
Sep 1, 2022
Arhell
approved these changes
Sep 2, 2022
Contributor
|
Thanks, i didn't think of that |
nlespiaucq
pushed a commit
to nlespiaucq/CodeceptJS
that referenced
this pull request
Oct 27, 2022
* REST: Changed endpoint to optional
REST API methods can be called with absolute URL ("https://") and therefore the property "endpoint" doesn't need to be specified in general
* Fixed REST helper docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
When I switched to TypeScript config in CodeceptJS 3.3.5, CodeceptJS forced me to specify
endpoint: ""though I don't use this property at all.Every REST API call in my tests is performed to absolute URL
http(s)://(because test switches between several servers), so I don't needendpointMoreover I noticed that default value of
endpointin REST helper is already an empty string, so I think that it's not needed to specify it from test's config:https://github.com/codeceptjs/CodeceptJS/blob/3.x/lib/helper/REST.js#L62
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)