Remove need for sponsor avatar #2224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will remove the need for an avatar for sponsors. This should be a temporary change, but will allow admins to continue creating new sponsors
junocchi
approved these changes
Jul 18, 2025
This reverts commit 3c3252c.
I've used a blank square from Wikipedia as a default for the avatar. This is a little brittle, because it assumes wikipedia will always be around and that we can use the square. We could alter this to be a square that we own, if we wanted. This should be changed as soon as we've properly fixed the logo upload
|
This now defaults to a blank square, hosted on Wikipedia |
| latitude longitude directions], | ||
| contacts_attributes: %i[id name surname email mailing_list_consent | ||
| _destroy]) | ||
| .with_defaults(avatar: "https://en.m.wikipedia.org/wiki/File:Blank_Square.svg") |
There was a problem hiding this comment.
Do their ToU allow remote loading like this?
There was a problem hiding this comment.
That's a good point. I think very technically no. We could download and host it somewhere - in which case, are we moving towards #2226 anyway?
There was a problem hiding this comment.
I believe that is allowed 🙂
There was a problem hiding this comment.
Short term, if someone in the organisation hosts it, we could use that? Or I can stick it in the S3 bucket I made for #2226 ?
There was a problem hiding this comment.
We could even host it here on Github, maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the need for an avatar for sponsors. This should be a temporary change, but will allow admins to continue creating new sponsors