Save branch setting when new environment added #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
==========================================
- Coverage 50.5% 50.33% -0.17%
==========================================
Files 74 74
Lines 8388 8415 +27
==========================================
Hits 4236 4236
- Misses 3641 3667 +26
- Partials 511 512 +1 |
aballman
suggested changes
Jul 16, 2019
| @@ -297,6 +297,36 @@ func (r *ProjectResolverMutation) UpdateProjectEnvironments(ctx context.Context, | |||
| EnvironmentID: environment.Model.ID, | |||
| ProjectID: project.Model.ID, | |||
| } | |||
|
|
|||
| // Save branch if this is a new environment | |||
| if r.DB.Where("environment_id = ? and project_id = ?", environment.Model.ID, project.Model.ID).Find(&projectEnvironment).RecordNotFound() { | |||
There was a problem hiding this comment.
Can you please use gorm.IsRecordNotFoundError (i think that's the right function)
to determine if it is a RecordNotFound error or not? If it's not a simple record not found, like there being a DB constraint or some sort of other error, we should log it.
You would do if err := r.DB.Where(query).Find(&model).Error; err != nil and then if gorm.IsRecordNotFoundError(err)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #455. Call
UpdateProjectwith default setting when new environment provisioned.