Ignore ports variable if length is 0 #433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only go through the ports-creation logic in the service mutation if the length of the ports input is greater than 0. Currently, we pass in a ports variable from the client-side regardless of the service type. However, the one-shot service type passes in a 0 length, non-nil ports parameter which means we cannot create one-shot services from the panel client inputs right now.
This fixes it by allowing to hit ports creation logic only if it is not nil and the ports length is greater than 0.