Fixes for 97, 98, 99 #127
Closed
Fixes for 97, 98, 99 #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrdTnc
suggested changes
Jul 29, 2019
| window.requestAnimationFrame(scrollSmoothly); | ||
| window.scrollTo(0, currentScroll - (currentScroll / 8)); | ||
| } | ||
| })(); |
There was a problem hiding this comment.
a little bit hacky. can you use scrollIntoView instead? there's neat example in approve-app.component (line 85) that method could be extracted overall and used anywhere we need it
There was a problem hiding this comment.
@y0rg1 can you please check? thanks 😄
There was a problem hiding this comment.
@lrdTnc I'm not entirely sure how to implement this cleanly using scrollIntoView because the navbar component (or any other top page component) is outside add-app's hierarchy.
I went with this approach in order to enable smooth scrolling on Edge and IE browsers as well.
|
continued this here #132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for the add app page: