-
Notifications
You must be signed in to change notification settings - Fork 0
사용자는 rxjs
subscription 을 활용해 네이버 2중 인증으로도 로그인 할 수 있습니다.
#6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
===========================================
+ Coverage 14.06% 43.75% +29.68%
===========================================
Files 4 3 -1
Lines 64 32 -32
Branches 8 0 -8
===========================================
+ Hits 9 14 +5
+ Misses 55 18 -37
Continue to review full report at Codecov.
|
rxjs
subscription 을 활용해 네이버 2중 인증으로도 로그인 할 수 있습니다..rxjs
subscription 을 활용해 네이버 2중 인증으로도 로그인 할 수 있습니다.
b1195aa
to
74e3374
Compare
OTP 인증과 (추후 추가될) 캡챠를 위해 rx 스트림을 반환하도록 합니다.
CI를 실패시키지 않도록 함
6b48543
to
da1bd3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dist
의 파일들을 테스트 하지 않도록 변경rxjs
의존성 추가pageInteractor.login()
을 더 atomic 하게 분리for .. of
대신Promise.all
를 사용해 히스토리를 반환하도록 변경PageInteractor
가ElementParser
를 인자로 받도록 변경LoginEvent
타입 추가