Skip to content

Conversation

code-yeongyu
Copy link
Owner

@code-yeongyu code-yeongyu commented Jan 16, 2022

  • dist 의 파일들을 테스트 하지 않도록 변경
  • rxjs 의존성 추가
    • 가독성을 개선합니다.
  • pageInteractor.login() 을 더 atomic 하게 분리
  • for .. of 대신 Promise.all 를 사용해 히스토리를 반환하도록 변경
    • 속도를 개선합니다.
  • PageInteractorElementParser 를 인자로 받도록 변경
  • LoginEvent 타입 추가
  • 예제 코드에 loginEvent 예제 추가
  • 1.0.0

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2022

Codecov Report

Merging #6 (74e3374) into master (c2e0fe0) will increase coverage by 29.68%.
The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
+ Coverage   14.06%   43.75%   +29.68%     
===========================================
  Files           4        3        -1     
  Lines          64       32       -32     
  Branches        8        0        -8     
===========================================
+ Hits            9       14        +5     
+ Misses         55       18       -37     
Impacted Files Coverage Δ
src/app/naver/service.ts 0.00% <0.00%> (ø)
src/app/naver/moduleFactory.ts 100.00% <100.00%> (+100.00%) ⬆️
src/app/naver/pageInteractor.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e0fe0...74e3374. Read the comment docs.

@code-yeongyu code-yeongyu changed the title 사용자는 rxjs subscription 을 활용해 네이버 2중 인증으로도 로그인 할 수 있습니다.. 사용자는 rxjs subscription 을 활용해 네이버 2중 인증으로도 로그인 할 수 있습니다. Jan 16, 2022
@code-yeongyu code-yeongyu force-pushed the naver-2fa branch 4 times, most recently from b1195aa to 74e3374 Compare January 19, 2022 06:56
@code-yeongyu code-yeongyu merged commit 5ff7831 into master Jan 19, 2022
@code-yeongyu code-yeongyu deleted the naver-2fa branch January 19, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants