-
Notifications
You must be signed in to change notification settings - Fork 16
test(examples-plugins): do not use memfs in integration tests, intended for unit tests only #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ed for unit tests only
|
View your CI Pipeline Execution ↗ for commit de43f5f
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit de43f5f
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 9706fb1 with previous commit d5ca550. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 2 audits improved, 👎 3 audits regressed, 16 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
589 other audits are unchanged. |
Some integration tests in example plugins were using
memfsmocks. This breaks our testing strategy - only unit tests should be using a mock file system, integration and E2E tests should use the real file system intmp.