Skip to content

Conversation

@matejchalk
Copy link
Collaborator

Some integration tests in example plugins were using memfs mocks. This breaks our testing strategy - only unit tests should be using a mock file system, integration and E2E tests should use the real file system in tmp.

@matejchalk matejchalk requested a review from BioPhoton as a code owner October 14, 2025 15:51
@github-actions github-actions bot added the 🔬 testing writing tests label Oct 14, 2025
@nx-cloud
Copy link

nx-cloud bot commented Oct 14, 2025

View your CI Pipeline Execution ↗ for commit de43f5f

Command Status Duration Result
nx code-pushup --nx-bail -- compare ✅ Succeeded 52s View ↗
nx code-pushup --nx-bail -- ✅ Succeeded 58s View ↗
nx code-pushup --nx-bail -- print-config --outp... ✅ Succeeded 3m 40s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-14 15:58:41 UTC

@nx-cloud
Copy link

nx-cloud bot commented Oct 14, 2025

View your CI Pipeline Execution ↗ for commit de43f5f

Command Status Duration Result
nx affected -t int-test --parallel=3 ✅ Succeeded 2s View ↗
nx affected -t e2e-test --parallel=1 ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-14 15:52:21 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 14, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1127

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1127

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1127

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1127

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1127

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1127

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1127

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1127

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1127

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1127

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1127

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1127

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1127

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1127

commit: de43f5f

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 9706fb1 with previous commit d5ca550.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Updates 🟡 84 🟡 81 ↓ −3.4
Performance 🔴 36 🔴 35 ↓ −0.7
Code coverage 🟡 90 🟡 90 ↑ +0.1
Security 🟡 56 🟡 56
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 24 🔴 24
👍 1 group improved, 👎 2 groups regressed, 👍 2 audits improved, 👎 3 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JS Packages NPM outdated dependencies 🟡 84 🟡 81 ↓ −3.4
Lighthouse Performance 🔴 36 🔴 35 ↓ −0.7
Code coverage Code coverage metrics 🟡 90 🟡 90 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JS Packages Outdated NPM prod dependencies. 🟨 16 outdated package versions (3 major, 9 minor, 4 patch) 🟨 16 outdated package versions (4 major, 8 minor, 4 patch)  +0 %
Lighthouse Total Blocking Time 🟥 1,760 ms 🟥 1,900 ms ↑ +7.6 %
Lighthouse Time to Interactive 🟥 13.8 s 🟥 13.2 s ↓ −4.2 %
Lighthouse Speed Index 🟥 7.0 s 🟥 7.1 s ↑ +0.8 %
Code coverage Branch coverage 🟨 85.5 % 🟨 85.5 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,071 KiB 🟩 Total size was 2,038 KiB ↓ −1.6 %
Lighthouse Server Backend Latencies 🟩 260 ms 🟩 1,240 ms ↑ +385.6 %
Lighthouse Minimizes main-thread work 🟥 12.3 s 🟥 13.1 s ↑ +5.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −4.2 %
Lighthouse JavaScript execution time 🟥 5.2 s 🟥 4.7 s ↓ −10.7 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Largest Contentful Paint 🟥 11.2 s 🟥 11.5 s ↑ +2 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 102 KiB 🟥 Potential savings of 102 KiB ↑ +34 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 180 KiB 🟥 Potential savings of 181 KiB ↑ +17 %
Lighthouse Max Potential First Input Delay 🟥 1,400 ms 🟥 1,270 ms ↓ −9.7 %
Lighthouse Initial server response time was short 🟥 Root document took 760 ms 🟥 Root document took 640 ms ↓ −14.7 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.1 s ↓ −0.3 %
JS Packages Vulnerabilities for NPM dev dependencies. 🟥 15 vulnerabilities (1 critical, 5 moderate, 9 low) 🟥 19 vulnerabilities (1 critical, 10 moderate, 8 low) ↑ +26.7 %
Lighthouse Avoids an excessive DOM size 🟥 2,263 elements 🟥 2,267 elements ↑ +0.2 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 50 ms ↓ −0.5 %
Code coverage Line coverage 🟨 86.3 % 🟨 86.3 % ↑ +0.1 %

589 other audits are unchanged.

@matejchalk matejchalk merged commit 42fa531 into main Oct 15, 2025
22 checks passed
@matejchalk matejchalk deleted the fix-example-plugin-int-test-fs-mock branch October 15, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants