Skip to content

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Sep 1, 2025

This PR includes:

  • use executeProcess in cli executor to log process output

This changes are needed to be able to use the plugin in combination with the CI actions on all platforms

Closes: #63

Copy link

nx-cloud bot commented Sep 1, 2025

View your CI Pipeline Execution ↗ for commit ca665fa

Command Status Duration Result
nx code-pushup --nx-bail -- compare --verbose ✅ Succeeded 1m 37s View ↗
nx code-pushup --nx-bail -- --verbose ✅ Succeeded 1m 45s View ↗
nx code-pushup --nx-bail -- print-config --verb... ✅ Succeeded 10m 8s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-02 17:09:12 UTC

@github-actions github-actions bot added the 🔬 testing writing tests label Sep 1, 2025
Copy link

pkg-pr-new bot commented Sep 1, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1095

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1095

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1095

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1095

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1095

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1095

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1095

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1095

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1095

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1095

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1095

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1095

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1095

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1095

commit: ca665fa

Copy link
Contributor

github-actions bot commented Sep 1, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 328fc0f with previous commit 4367e53.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 33 🔴 31 ↓ −2.6
Code coverage 🟢 90 🟢 90 ↓ −0.2
Security 🟡 64 🟡 64
Updates 🟡 85 🟡 85
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👎 2 groups regressed, 👍 1 audit improved, 👎 6 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 33 🔴 31 ↓ −2.6
Code coverage Code coverage metrics 🟢 90 🟢 90 ↓ −0.2

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Properly size images 🟨 Potential savings of 5 KiB 🟩 0  −∞ %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.6 s ↑ +12.8 %
Lighthouse Speed Index 🟥 7.1 s 🟥 7.6 s ↑ +7.8 %
Lighthouse Total Blocking Time 🟥 2,960 ms 🟥 4,630 ms ↑ +56.3 %
Code coverage Line coverage 🟨 87.5 % 🟨 87.2 % ↓ −0.3 %
Code coverage Function coverage 🟩 93 % 🟩 92.8 % ↓ −0.2 %
Code coverage Branch coverage 🟨 86.3 % 🟨 86.2 % ↓ −0.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 32 resources found 🟨 30 resources found ↓ −1 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,687 KiB 🟨 Total size was 2,683 KiB ↓ −0.2 %
Lighthouse Minimizes main-thread work 🟥 13.3 s 🟥 16.0 s ↑ +20.7 %
Lighthouse JavaScript execution time 🟥 5.5 s 🟥 7.4 s ↑ +35.6 %
Lighthouse Largest Contentful Paint 🟥 11.4 s 🟥 12.0 s ↑ +5.6 %
Lighthouse Max Potential First Input Delay 🟥 1,310 ms 🟥 1,760 ms ↑ +34.2 %
Lighthouse Time to Interactive 🟥 17.4 s 🟥 17.7 s ↑ +1.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +1.7 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 582 KiB 🟥 Potential savings of 583 KiB ↑ +24.4 %
Lighthouse Server Backend Latencies 🟩 1,310 ms 🟩 1,120 ms ↓ −14.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 113 KiB 🟥 Potential savings of 113 KiB ↓ −20 %
Lighthouse Initial server response time was short 🟩 Root document took 500 ms 🟩 Root document took 380 ms ↓ −23.9 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 101 KiB 🟥 Potential savings of 101 KiB ↑ +6.7 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 60 ms ↓ −13.6 %
Lighthouse Avoids an excessive DOM size 🟥 2,285 elements 🟥 2,283 elements ↓ −0.1 %

588 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review September 1, 2025 21:16
@BioPhoton BioPhoton requested a review from matejchalk September 1, 2025 21:16
@BioPhoton BioPhoton changed the title fix(nx-plugin): print stdout for CLI command fix(nx-plugin): print process output for CLI command Sep 1, 2025
matejchalk
matejchalk previously approved these changes Sep 2, 2025
@BioPhoton BioPhoton requested a review from matejchalk September 2, 2025 17:22
@BioPhoton BioPhoton merged commit b85316d into main Sep 2, 2025
17 checks passed
@BioPhoton BioPhoton deleted the fix/nx-plugin/print-stdout branch September 2, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nx plugin - cli executor for the code pushup CLI

2 participants