test: introduce test-vitest-setup #1067

AndriiSiuta · 2025-08-15T15:35:56Z

pkg-pr-new · 2025-08-15T15:37:40Z

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1067

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1067

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1067

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1067

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1067

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1067

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1067

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1067

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1067

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1067

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1067

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1067

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1067

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1067

commit: 39f4030

BioPhoton

Thx for starting this refactor! Looking forward to a clean test config setup.

Some remarks, If you open a PR and request a review please do a self review.

Check if:

all changes are applied in a consistent way. Not different versions for the same change. E.g. you extend the global configuration in different ways.
do not add code changes out of scope. If they are necessary mention them in a comment
potentially add information on the state of the PR e.g. DO NOT REVIEW and additional comments about unfinished parts.
If you use AI do an extra detailed review!

eslint.config.js

packages/core/vitest.int.config.ts

packages/models/eslint.config.js

packages/models/transformers/eslint.config.cjs

packages/utils/vitest.unit.config.ts

testing/test-vitest-setup/README.md

nx-cloud · 2025-08-22T09:27:58Z

View your CI Pipeline Execution ↗ for commit 39f4030

Command	Status	Duration	Result
`nx code-pushup --nx-bail -- print-config --verb...`	❌ Failed	6s	View ↗

☁️ Nx Cloud last updated this comment at 2025-08-29 12:47:14 UTC

BioPhoton · 2025-08-22T14:53:41Z

testing/test-vitest-setup/src/utils/project-config.ts

+type CoverageConfig = {
+  enabled?: boolean;
+  provider: 'v8';
+  reporter: ('text' | 'lcov')[];
+  reportsDirectory: string;
+  include: string[];
+  exclude: string[];
+};


You could use the types from vite/vitest directly:

// from vite import type { UserConfig } from 'vite'; type TestCoverage = Exclude<UserConfig['test'], undefined>; // from vitest import type { UserConfig } from 'vitest'; type TestCoverage = UserConfig; // for both const testConfig: TestCoverage = { coverage: { reporter: ['text', 'lcov'], reportsDirectory: '../../coverage/plugin-eslint/int-tests', exclude: ['mocks/**', '**/types.ts'], }, };

I suggest go with types from vitest and remove the types in this file.

I saw you removed the custom types. Thanks!
I also saw you just do not us types now in your helpers.

Please use the types in:

getDefaultTestSettings return type TestCoverage['coverage'] from import type { UserConfig } from 'vitest'

createSharedVitestConfig return type UserConfig from import type { UserConfig } from 'vitest'

createSharedUnitVitestConfig return type UserConfig from import type { UserConfig } from 'vitest'

createSharedIntegrationVitestConfig return type UserConfig from import type { UserConfig } from 'vitest'

createSharedE2eVitestConfig return type UserConfig from import type { UserConfig } from 'vitest'

... also look at other places that could improve typing

testing/test-vitest-setup/src/utils/tsconfig-path-aliases.ts

testing/test-vitest-setup/eslint.config.js

BioPhoton · 2025-09-01T13:21:45Z

examples/plugins/src/file-size/src/file-size.plugin.unit.test.ts


  it('should return pass if no files are given and pass', async () => {
    vol.reset();
-    // create empty directory


This is out of scope and not needed- revert pls.

BioPhoton · 2025-09-01T13:22:12Z

packages/ci/src/lib/monorepo/packages.unit.test.ts

    vol.fromJSON(
      {
        'e2e/package.json': pkgJsonContent({ name: 'e2e' }),
-        'package.json': pkgJsonContent({ name: 'example-monorepo' }), // not in patterns


This is out of scope and not needed. Please revert.

BioPhoton · 2025-09-01T13:22:21Z

packages/ci/src/lib/monorepo/packages.unit.test.ts

          workspaces: ['ui', 'api'],
        }),
        'api/package.json': pkgJsonContent({ name: 'api' }),
-        'e2e/package.json': pkgJsonContent({ name: 'e2e' }), // not in workspaces


This is out of scope and not needed. Please revert.

BioPhoton · 2025-09-01T13:22:37Z

packages/cli/src/lib/autorun/autorun-command.unit.test.ts

      }),
    );

-    // values come from CORE_CONFIG_MOCK returned by readRcByPath mock


This is out of scope and not needed. Please revert.

BioPhoton

Hi! Thanks for resolving some of the comments!

For next steps and to get this in faster i suggest the following:

please add a proper PR description that contains the scope and planned changes
do not add code changes out of scope. If they are necessary mention them in a comment.
This happened the 3rd time in a row now and makes it impossible to merge. This time you did remove the AI comments as mentioned, but you also removed comments all over the code base. I mentioned some of the places in comments.
If you use AI do an extra detailed review! This was the case in all PR's so far and made the review a bit more harder/longer, as the changes needs to get pointed out individually and reverted again. By doing a self review those D-tours could be avoided or at least reduced.

For the PR description that defines the scope I suggest the following:

This PR includes:

Introduce test-vitest-setup and add configuration

adjust coverage.reportDirectory to be at project root (packages/<name>/.coverage)

Related:

#1065

With this scope I would suggest revert all changed other than the folder testing/test-vitest-setup
The comment regarding typing got updated and should serve now also the places where you can use the types. This should clear any misunderstanding. If there is something unclear regarding the types please let me know.
Comment: #1067 (comment)

BioPhoton · 2025-09-08T22:03:39Z

Close as reopened in other PRs.

test: introduce test-vitest-setup

72b6379

AndriiSiuta requested review from BioPhoton and matejchalk as code owners August 15, 2025 15:35

github-actions bot assigned AndriiSiuta Aug 15, 2025

github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling labels Aug 15, 2025

fix: handle function-based Vitest configs in coverage plugin

71b5e2c

github-actions bot added the 🧩 coverage-plugin label Aug 15, 2025

BioPhoton requested changes Aug 15, 2025

View reviewed changes

fix: fix mr comments

6c1e082

github-actions bot removed the 📖 Project documentation improvements or additions to the project documentation label Aug 22, 2025

Merge branch 'main' into test-vitest-setup

39ddacc

AS added 4 commits August 22, 2025 12:39

fix: module bounderies off

e8496b8

fix: coverage path fixes

54f0ea7

fix: coverage fallback

1416c5e

fix: lint and format

3551706

AndriiSiuta requested a review from BioPhoton August 22, 2025 10:16

BioPhoton reviewed Aug 22, 2025

View reviewed changes

testing/test-vitest-setup/src/utils/tsconfig-path-aliases.ts Outdated Show resolved Hide resolved

BioPhoton reviewed Aug 22, 2025

View reviewed changes

testing/test-vitest-setup/eslint.config.js Outdated Show resolved Hide resolved

github-actions bot added 🧩 cli 🧩 core 🧩 utils 🧩 nx-plugin 🧩 eslint-plugin 🧩 lighthouse-plugin 🧩 typescript-plugin TypeScript plugin labels Aug 29, 2025

github-actions bot added 🧩 ci 🧩 create-cli labels Aug 29, 2025

AndriiSiuta added 2 commits August 29, 2025 14:57

test: fix mr comments and configuration

1b94803

test: merge main and resolve conflicts

39f4030

BioPhoton reviewed Sep 1, 2025

View reviewed changes

BioPhoton requested changes Sep 1, 2025

View reviewed changes

BioPhoton mentioned this pull request Sep 4, 2025

test: introduce test-vitest-setup project to handle test setup for vite tests #1065

Open

15 tasks

BioPhoton closed this Sep 8, 2025

test: introduce test-vitest-setup #1067

test: introduce test-vitest-setup #1067

Uh oh!

Conversation

AndriiSiuta commented Aug 15, 2025

Uh oh!

pkg-pr-new bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BioPhoton left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nx-cloud bot commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BioPhoton Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

BioPhoton Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BioPhoton Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

BioPhoton Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

BioPhoton Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

BioPhoton Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

BioPhoton left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BioPhoton commented Sep 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pkg-pr-new bot commented Aug 15, 2025 •

edited

Loading

BioPhoton left a comment •

edited

Loading

nx-cloud bot commented Aug 22, 2025 •

edited

Loading

BioPhoton Sep 1, 2025 •

edited

Loading

BioPhoton left a comment •

edited

Loading