Skip to content

Adding player moves and correct moves verifier #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 16, 2024
Merged

Adding player moves and correct moves verifier #501

merged 4 commits into from
Nov 16, 2024

Conversation

elimanzo
Copy link
Contributor

Added a verifier for player moves and correct moves

DominicS99
DominicS99 approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@DominicS99 DominicS99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to clean up the if statements to be more concise (if !isCorrectSequence, then remaining ifs shouldn't need to confirm isCorrectSequence === true)

@elimanzo elimanzo merged commit d97371c into main Nov 16, 2024
9 checks passed
@elimanzo elimanzo deleted the em-verifying-moves branch November 16, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominicS99 DominicS99 DominicS99 approved these changes

@miorel miorel Awaiting requested review from miorel miorel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elimanzo @DominicS99