Redo Chrome extension to be based on patching JSON.parse
#468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, I thought that the packages LeetCode uses would implement their own JSON parsing. (This is perhaps because I remembered that some packages like Express implement their own JSON stringification.) In any case, it looks like the built-in `JSON.parse` is what they use, because we can get the same functionality as before by patching `JSON.parse`. Some of the other functions I've been playing around with while developing the extension are nevertheless useful, so I'm keeping them as part of the `util` workspace.
miorel
force-pushed
the
patch-json-parse
branch
from
2b506ee to
95b58e2
Compare
miorel
force-pushed
the
patch-json-parse
branch
from
03e18fd to
7360730
Compare
simona1
approved these changes
Oct 16, 2024
miorel
added a commit
that referenced
this pull request
Oct 18, 2024
)" This reverts commit 92d04ee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, I thought that the packages LeetCode uses would implement their own JSON parsing. (This is perhaps because I remembered that some packages like Express implement their own JSON stringification.)
In any case, it looks like the built-in
JSON.parseis what they use, because we can get the same functionality as before by patchingJSON.parse. Some of the other functions I've been playing around with while developing the extension are nevertheless useful, so I'm keeping them as part of theutilworkspace.