Skip to content

Use fork-ts-checker-webpack-plugin to typecheck during webpack #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Use fork-ts-checker-webpack-plugin to typecheck during webpack #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions workspaces/adventure-pack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
"@types/react-syntax-highlighter": "15.5.13",
"cross-env": "7.0.3",
"eslint": "9.11.1",
"fork-ts-checker-webpack-plugin": "9.0.2",
"jest": "29.7.0",
"prettier": "3.3.3",
"prettier-plugin-java": "2.6.4",
Expand Down
8 changes: 5 additions & 3 deletions workspaces/adventure-pack/webpack.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { execSync } from "node:child_process";
import path from "node:path";

import webpack, { type Configuration } from "webpack";
import { DefinePlugin, type Configuration } from "webpack";
import ForkTsCheckerWebpackPlugin from "fork-ts-checker-webpack-plugin";

import { WEB_APP_DIST } from "./src/scripts/build/constants.ts";

Expand All @@ -24,7 +25,6 @@ const config: Configuration = {
{
loader: "ts-loader",
options: {
// TODO: Consider using fork-ts-checker-webpack-plugin for typechecking.
transpileOnly: true,
},
},
Expand All @@ -39,9 +39,11 @@ const config: Configuration = {
},

plugins: [
new webpack.DefinePlugin({
new DefinePlugin({
ADVENTURE_PACK_COMMIT_HASH: JSON.stringify(commitHash),
}),

new ForkTsCheckerWebpackPlugin(),
],

optimization: {
Expand Down
1 change: 1 addition & 0 deletions workspaces/download-leetcode-submissions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"@types/node": "22.7.4",
"cross-env": "7.0.3",
"eslint": "9.11.1",
"fork-ts-checker-webpack-plugin": "9.0.2",
"prettier": "3.3.3",
"ts-loader": "9.5.1",
"tsx": "4.19.1",
Expand Down
9 changes: 6 additions & 3 deletions workspaces/download-leetcode-submissions/webpack.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import { builtinModules } from "node:module";
import path from "node:path";

import webpack, {
import {
BannerPlugin,
type Configuration,
type ExternalItemFunctionData,
} from "webpack";
import ForkTsCheckerWebpackPlugin from "fork-ts-checker-webpack-plugin";

import { stripPrefix } from "@code-chronicles/util/stripPrefix";
import { stripPrefixOrThrow } from "@code-chronicles/util/stripPrefixOrThrow";
Expand All @@ -28,7 +30,6 @@ const config: Configuration = {
{
loader: "ts-loader",
options: {
// TODO: Consider using fork-ts-checker-webpack-plugin for typechecking.
transpileOnly: true,
},
},
Expand All @@ -53,11 +54,13 @@ const config: Configuration = {
),

plugins: [
new webpack.BannerPlugin({
new BannerPlugin({
banner: "#!/usr/bin/env node\n",
raw: true,
entryOnly: true,
}),

new ForkTsCheckerWebpackPlugin(),
],
};

Expand Down
1 change: 1 addition & 0 deletions workspaces/fetch-leetcode-problem-list/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"@types/node": "22.7.4",
"cross-env": "7.0.3",
"eslint": "9.11.1",
"fork-ts-checker-webpack-plugin": "9.0.2",
"prettier": "3.3.3",
"ts-loader": "9.5.1",
"tsx": "4.19.1",
Expand Down
11 changes: 7 additions & 4 deletions workspaces/fetch-leetcode-problem-list/webpack.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@ import { chmod } from "node:fs/promises";
import { builtinModules } from "node:module";
import path from "node:path";

import webpack, {
import {
BannerPlugin,
type Compiler,
type Configuration,
type ExternalItemFunctionData,
} from "webpack";
import ForkTsCheckerWebpackPlugin from "fork-ts-checker-webpack-plugin";

import { stripPrefix } from "@code-chronicles/util/stripPrefix";
import { stripPrefixOrThrow } from "@code-chronicles/util/stripPrefixOrThrow";
Expand All @@ -16,7 +18,7 @@ import packageJson from "./package.json" with { type: "json" };
class WebpackMakeOutputExecutablePlugin {
// eslint-disable-next-line class-methods-use-this -- This is the interface expected by webpack.
apply(compiler: Compiler): void {
compiler.hooks.afterEmit.tapAsync(
compiler.hooks.afterEmit.tapPromise(
"WebpackMakeOutputExecutablePlugin",
async (compilation) => {
const promises: Promise<void>[] = [];
Expand Down Expand Up @@ -59,7 +61,6 @@ const config: Configuration = {
{
loader: "ts-loader",
options: {
// TODO: Consider using fork-ts-checker-webpack-plugin for typechecking.
transpileOnly: true,
},
},
Expand All @@ -84,13 +85,15 @@ const config: Configuration = {
),

plugins: [
new webpack.BannerPlugin({
new BannerPlugin({
banner: "#!/usr/bin/env node\n",
raw: true,
entryOnly: true,
}),

new WebpackMakeOutputExecutablePlugin(),

new ForkTsCheckerWebpackPlugin(),
],
};

Expand Down
1 change: 1 addition & 0 deletions workspaces/fetch-recent-accepted-leetcode-submissions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"@types/node": "22.7.4",
"cross-env": "7.0.3",
"eslint": "9.11.1",
"fork-ts-checker-webpack-plugin": "9.0.2",
"prettier": "3.3.3",
"ts-loader": "9.5.1",
"tsx": "4.19.1",
Expand Down
9 changes: 6 additions & 3 deletions workspaces/fetch-recent-accepted-leetcode-submissions/webpack.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import { builtinModules } from "node:module";
import path from "node:path";

import webpack, {
import {
BannerPlugin,
type Configuration,
type ExternalItemFunctionData,
} from "webpack";
import ForkTsCheckerWebpackPlugin from "fork-ts-checker-webpack-plugin";

import { stripPrefix } from "@code-chronicles/util/stripPrefix";
import { stripPrefixOrThrow } from "@code-chronicles/util/stripPrefixOrThrow";
Expand All @@ -28,7 +30,6 @@ const config: Configuration = {
{
loader: "ts-loader",
options: {
// TODO: Consider using fork-ts-checker-webpack-plugin for typechecking.
transpileOnly: true,
},
},
Expand All @@ -53,11 +54,13 @@ const config: Configuration = {
),

plugins: [
new webpack.BannerPlugin({
new BannerPlugin({
banner: "#!/usr/bin/env node\n",
raw: true,
entryOnly: true,
}),

new ForkTsCheckerWebpackPlugin(),
],
};

Expand Down
1 change: 1 addition & 0 deletions workspaces/leetcode-zen-mode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"@types/node": "22.7.4",
"cross-env": "7.0.3",
"eslint": "9.11.1",
"fork-ts-checker-webpack-plugin": "9.0.2",
"prettier": "3.3.3",
"ts-loader": "9.5.1",
"tsx": "4.19.1",
Expand Down
4 changes: 3 additions & 1 deletion workspaces/leetcode-zen-mode/webpack.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import path from "node:path";

import type { Configuration } from "webpack";
import ForkTsCheckerWebpackPlugin from "fork-ts-checker-webpack-plugin";

import packageJson from "./package.json" with { type: "json" };

Expand All @@ -20,7 +21,6 @@ const config: Configuration = {
{
loader: "ts-loader",
options: {
// TODO: Consider using fork-ts-checker-webpack-plugin for typechecking.
transpileOnly: true,
},
},
Expand All @@ -33,6 +33,8 @@ const config: Configuration = {
resolve: {
conditionNames: ["import"],
},

plugins: [new ForkTsCheckerWebpackPlugin()],
};

export default config;
1 change: 1 addition & 0 deletions workspaces/post-leetcode-potd-to-discord/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"@types/node": "22.7.4",
"cross-env": "7.0.3",
"eslint": "9.11.1",
"fork-ts-checker-webpack-plugin": "9.0.2",
"prettier": "3.3.3",
"tsx": "4.19.1",
"typescript": "5.6.2",
Expand Down
9 changes: 6 additions & 3 deletions workspaces/post-leetcode-potd-to-discord/webpack.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import { builtinModules } from "node:module";
import path from "node:path";

import webpack, {
import {
BannerPlugin,
type Configuration,
type ExternalItemFunctionData,
} from "webpack";
import ForkTsCheckerWebpackPlugin from "fork-ts-checker-webpack-plugin";

import { stripPrefix } from "@code-chronicles/util/stripPrefix";
import { stripPrefixOrThrow } from "@code-chronicles/util/stripPrefixOrThrow";
Expand All @@ -28,7 +30,6 @@ const config: Configuration = {
{
loader: "ts-loader",
options: {
// TODO: Consider using fork-ts-checker-webpack-plugin for typechecking.
transpileOnly: true,
},
},
Expand Down Expand Up @@ -59,11 +60,13 @@ const config: Configuration = {
],

plugins: [
new webpack.BannerPlugin({
new BannerPlugin({
banner: "#!/usr/bin/env node\n",
raw: true,
entryOnly: true,
}),

new ForkTsCheckerWebpackPlugin(),
],
};

Expand Down
Loading
Loading