Skip to content

Conversation

miorel
Copy link
Contributor

@miorel miorel commented Sep 15, 2024

@miorel miorel force-pushed the leetcode-api-module branch from ef9a128 to 7ef8da5 Compare September 16, 2024 00:43
@miorel miorel force-pushed the leetcode-api-module branch from 1e716a3 to 2cdd423 Compare September 16, 2024 01:48
@miorel miorel marked this pull request as ready for review September 16, 2024 01:49
@miorel miorel requested review from elimanzo and simona1 September 16, 2024 01:49
Copy link
Contributor

@elimanzo elimanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! What was the reason behind migrating the workspace to a module.

@miorel
Copy link
Contributor Author

miorel commented Sep 16, 2024

I wanted to import an ESM package, which recursively requires its dependencies to be ESM.

Some reading:

@miorel miorel merged commit 220f83a into main Sep 16, 2024
6 checks passed
@miorel miorel deleted the leetcode-api-module branch September 16, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants