Skip to content

Conversation

VolodymyrSemenov
Copy link
Contributor

@VolodymyrSemenov VolodymyrSemenov commented Aug 22, 2024

Closes #340.

@VolodymyrSemenov VolodymyrSemenov linked an issue Aug 22, 2024 that may be closed by this pull request
@VolodymyrSemenov VolodymyrSemenov self-assigned this Aug 22, 2024
@VolodymyrSemenov VolodymyrSemenov added enhancement New feature or request python Adventure Pack Python issue labels Aug 22, 2024
@miorel miorel changed the title 340 add a transpose python goody Add a transpose python goody Aug 23, 2024
@miorel miorel changed the title Add a transpose python goody Add a transpose python goody Aug 23, 2024
@miorel miorel changed the title Add a transpose python goody Add a transpose Python goody Aug 26, 2024
transpose_matrix([[0], [0, 1]])


def test_nonsymetric_transpose() -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_nonsymetric_transpose() -> None:
def test_nonsymmetric_transpose() -> None:

Comment on lines +17 to +19
input_1 = [[0, 1, 2, 3], [4, 5, 6, 7], [8, 9, 10, 11]]
expected_1 = [[0, 4, 8], [1, 5, 9], [2, 6, 10], [3, 7, 11]]
input_2 = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go a step further and group the asserts too, so the entirety of that test case is co-located!

Suggested change
input_1 = [[0, 1, 2, 3], [4, 5, 6, 7], [8, 9, 10, 11]]
expected_1 = [[0, 4, 8], [1, 5, 9], [2, 6, 10], [3, 7, 11]]
input_2 = [
input_1 = [[0, 1, 2, 3], [4, 5, 6, 7], [8, 9, 10, 11]]
expected_1 = [[0, 4, 8], [1, 5, 9], [2, 6, 10], [3, 7, 11]]
assert transpose_matrix(input_1) == expected_1
input_2 = [

@miorel miorel merged commit e6c6a76 into main Sep 22, 2024
6 checks passed
@miorel miorel deleted the 340-add-a-transpose-python-goody branch September 22, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request python Adventure Pack Python issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a transpose Python Goody

2 participants