feat: add binary tree inorder traversal goody #315
Conversation
| yield node | ||
| continue | ||
|
|
||
| if node.right: |
There was a problem hiding this comment.
By the way, I think to the extent that the code remains idiomatic, it would be nice to have consistency across languages. I think so far in TypeScript and Java we've allowed nulls to be added to the stack. The advantage of that style is that there is only one if statement instead of 3. The advantage of this style is that, well, no nulls/Nones in the stack.
I'd probably still prefer the style with only one if statement because we repeat ourselves less, but if you're advocating for this style then we should change the Java and TypeScript code to stay consistent.
There was a problem hiding this comment.
@miorel I can see your point, with the TS tree traversal style we do not repeat the same code twice. I modified the code.
2 participants
Closes #174.