Skip to content

Conversation

@miorel
Copy link
Contributor

@miorel miorel commented Jul 11, 2024

Hypothetically we could use javafx.util.Pair but I don't love that the fields are named key and value. So let's reinvent the wheel!

@miorel miorel requested review from simona1 and volkmchl July 11, 2024 02:18
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024

PR Health Report

Last checked commit b297beb.

  • npx prettier --write .github .vscode && ! (git status --porcelain | grep .): ✅
  • (cd tools && yarn format && ! (git status --porcelain | grep .)): ✅
  • (cd tools && yarn lint): ✅
  • (cd tools && yarn typecheck): ✅
  • (cd tools && yarn test): ✅
  • (cd tools/adventure-pack && yarn build-app): ✅

Hypothetically we could use [`javafx.util.Pair`](https://docs.oracle.com/javase/8/javafx/api/javafx/util/Pair.html) but I don't love that the fields are named key and value. So let's reinvent the wheel!
@miorel miorel merged commit 722277e into main Jul 14, 2024
@miorel miorel deleted the java-pair branch July 14, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants