Skip to content

Slight improvement to Python typing #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

Slight improvement to Python typing #153

merged 1 commit into from
Jul 10, 2024

Conversation

@miorel
Copy link
Contributor

@miorel miorel commented Jul 9, 2024 •
edited
Loading

We also get ready to differentiate the goody name from the module name!

@miorel miorel requested review from elimanzo, simona1 and volkmchl July 9, 2024 06:40
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

PR Health Report

Last checked commit 14ced05.

  • npx prettier --write .github .vscode && ! (git status --porcelain | grep .): ✅
  • (cd tools && yarn format && ! (git status --porcelain | grep .)): ✅
  • (cd tools && yarn lint): ✅
  • (cd tools && yarn typecheck): ✅
  • (cd tools && yarn test): ✅
  • (cd tools/adventure-pack && yarn build-app): ✅

@miorel
Slight improvement to Python typing
14ced05 
We also get ready to differentiate the goody name from the module name!
@miorel miorel merged commit 6da5e9b into main Jul 10, 2024
@miorel miorel deleted the python3-typing branch July 10, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simona1 simona1 simona1 approved these changes

@volkmchl volkmchl Awaiting requested review from volkmchl

@elimanzo elimanzo Awaiting requested review from elimanzo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miorel @simona1