Skip to content

closed #3988: fix bug Node::setRotation() moves opposite when node has a... #5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2014
Merged

closed #3988: fix bug Node::setRotation() moves opposite when node has a... #5325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64cf608
closed #3988: fix bug Node::setRotation() moves opposite when node ha…
Feb 11, 2014
3d2d5ca
closed #3988: add bug test
Feb 12, 2014
be02897
closed #3988: fix indent.
Feb 12, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cocos/physics/CCPhysicsBody.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ void PhysicsBody::setPosition(Point position)

void PhysicsBody::setRotation(float rotation)
{
cpBodySetAngle(_info->getBody(), PhysicsHelper::float2cpfloat(rotation * M_PI / 180.0f));
cpBodySetAngle(_info->getBody(), -PhysicsHelper::float2cpfloat(rotation * M_PI / 180.0f));
}

Point PhysicsBody::getPosition() const
Expand Down
28 changes: 28 additions & 0 deletions tests/test-cpp/Classes/PhysicsTest/PhysicsTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ namespace
CL(PhysicsDemoPump),
CL(PhysicsDemoOneWayPlatform),
CL(PhysicsDemoSlice),
CL(PhysicsDemoBug3988),
#else
CL(PhysicsDemoDisabled),
#endif
Expand Down Expand Up @@ -1219,4 +1220,31 @@ std::string PhysicsDemoSlice::subtitle() const
return "click and drag to slice up the block";
}


void PhysicsDemoBug3988::onEnter()
{
PhysicsDemo::onEnter();
_scene->toggleDebug();
_scene->getPhysicsWorld()->setGravity(Vect::ZERO);

auto ball = Sprite::create("Images/YellowSquare.png");
ball->setPosition(VisibleRect::center() - Point(100, 0));
ball->setRotation(30.0f);
this->addChild(ball);

auto physicsBall = makeBox(VisibleRect::center() + Point(100, 0), Size(100, 100));
physicsBall->setRotation(30.0f);
this->addChild(physicsBall);
}

std::string PhysicsDemoBug3988::title() const
{
return "Bug3988";
}

std::string PhysicsDemoBug3988::subtitle() const
{
return "All the Rectangles should have same rotation angle";
}

#endif // ifndef CC_USE_PHYSICS
11 changes: 11 additions & 0 deletions tests/test-cpp/Classes/PhysicsTest/PhysicsTest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,5 +184,16 @@ class PhysicsDemoSlice : public PhysicsDemo
int _sliceTag;
};

class PhysicsDemoBug3988 : public PhysicsDemo
{
public:
CREATE_FUNC(PhysicsDemoBug3988);

void onEnter() override;
virtual std::string title() const override;
virtual std::string subtitle() const override;
};


#endif
#endif