add missing properties of cp.SegmentShape and cp.PolyShape #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dingpinglv @pandamicro take a look please |
|
Which test case can test its functionality ? |
|
No problem with the code logic. Need to test the functionality |
|
Test added |
|
Thanks, I will test it on Mac and iOS |
There was a problem hiding this comment.
I believe this should be the assert for b.y
|
Fixed, it will not crash now. |
|
Tested on Mac and iOS, good to merge |
dingpinglv
added a commit
that referenced
this pull request
Nov 7, 2014
add missing properties of cp.SegmentShape and cp.PolyShape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1048