Skip to content

Conversation

@himynameschris
Copy link

[socketio-jsb] add SocketIO JS extension test, update test menu and boot files
[socketio-jsb] add socket.io client library to external sources
[socketio-jsb] modify test to include getTag and setTag handlers
[socketio-jsb] correct on handler declarations and streamline client tagging with a map of names and sockets
[socketio-jsb] correct on handler declarations and streamline client tagging with a map of names and sockets
[socketio-jsb] further streamline jsb vs js codes
[socketio-jsb] remove sockets[] register in favor of tag property
[socketio-jsb] correct identifier

…iles

[socketio-jsb] add SocketIO JS extension test, update test menu and boot files
[socketio-jsb] add socket.io client library to external sources
[socketio-jsb] modify test to include getTag and setTag handlers
[socketio-jsb] correct on handler declarations and streamline client tagging with a map of names and sockets
[socketio-jsb] correct on handler declarations and streamline client tagging with a map of names and sockets
[socketio-jsb] further streamline jsb vs js codes
[socketio-jsb] remove sockets[] register in favor of tag property
[socketio-jsb] correct identifier

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where was this file located? It's a module in cocos2d-html5?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will open a PR on the cocos2d-html5 repo to clarify, but yes you are
correct.

It is the compiled version from the root directory of the learnboost repo
here (although it looks like they just posted new version yesterday):

https://github.com/LearnBoost/socket.io-client

On Wed, Feb 26, 2014 at 12:39 AM, James Chen [email protected]:

In tests-boot-html5.js:

@@ -44,6 +44,7 @@

         'tests_resources-html5.js',
         'tests-main.js',
  •        '../external/socket.io/socket.io.js',
    

Where was this file located? It's a module in cocos2d-html5?

Reply to this email directly or view it on GitHubhttps://github.com//pull/320/files#r10069020
.

@dumganhar
Copy link

@dingpinglv
Could you please review and test this PR? I think it's a great feature for JSB and html5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants