DOC-14614: Product Change- PR #151689 - sql: add routine statement counters for tracking execution metrics #20860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated metrics.yaml, ran `./cockroach gen metric-list > metrics.yaml` with v25.4.0-rc.1 binary. In v25.3/essential-metrics.md and v25.4/essential-metrics.md, fixed bug where it mentioned self-hosted on Advanced page. In v25.4/essential-metrics.md, added sections for Physical Replication and Logical Replication.
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@ZhouXing19 please review the changes to these pages: Available Metrics |
ZhouXing19
approved these changes
Oct 30, 2025
taroface
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
LGTM, assuming all the copy associated with these metrics, and their inclusion on the Essential Metrics tables, results directly from generation and is not manual (i.e., the main thing I need to review is the inclusion of the 8 metrics in available-metrics-in-metrics-list.csv).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-14614
./cockroach gen metric-list > metrics.yamlwith v25.4.0-rc.1 binary.Rendered preview