pkg/cdi: rename test-files to have the correct suffix, and remove legacy build-tags #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thaJeztah
commented
Apr 3, 2025
thaJeztah
commented
- relates to https://github.com/moby/buildkit/pull/5856/files/161ae19e3c376c4c7a62074d2458679ee81ea889#r2010704152
Make sure these files are only considered for tests. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Go module requires go1.20, so we no longer need to take the old format into account. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Contributor
Author
elezar
approved these changes
Apr 3, 2025
Contributor
elezar
left a comment
elezar
left a comment
There was a problem hiding this comment.
Thanks. I haven't gotten around to it yet.
Contributor
|
@thaJeztah how critical is it that this be included in a release? Is the dependency update blocked on this? |
Contributor
Author
|
No, I don't think it's critical to do a release specifically for this; AFAICS, it's fine to just roll up in an upcoming patch release if it would be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.