Skip to content

Conversation

@avli
Copy link
Contributor

@avli avli commented Jan 8, 2015

No description provided.

@avli
Copy link
Contributor Author

avli commented Jan 8, 2015

The example of the highlighting is on the screenshot below.

screen shot 2015-01-08 at 18 03 33

@cmur2
Copy link
Owner

cmur2 commented Jan 8, 2015

Cool! I personally don't use Exlixir (yet) but I'm happy to merge this :)

Would you mind putting your file under the GPLv2 license as the rest of the JOE source code so it could theoretically be bundled with it some day if one wants so? I'll merge regardless of your decision since this is very nice but I'd be happy if you think about it.

@utoddl
Copy link
Contributor

utoddl commented Jan 8, 2015

On 01/08/2015 09:45 AM, Christian Nicolai wrote:

Cool! I personally don't use Exlixir (yet) but I'm happy to merge this :)

Would you mind putting your file under the GPLv2 license as the rest of
the JOE source code so it could theoretically be bundled with it some
day if one wants so? I'll merge regardless of your decision since this
is very nice but I'd be happy if you think about it.

I would also like to point out that JOE is not the only editor which uses
JOE's syntax engine and .jsf files. At least one other, ne
(http://ne.di.unimi.it/) uses the same engine, and by having GPL'd .jsf
files we're able to include those with ne.

As such, I want to thank all those involved with the joe-syntax effort. It

goes beyond just JOE.

Todd

@avli
Copy link
Contributor Author

avli commented Jan 8, 2015

@cmur2 I don't mind putting this code under the GPLv2, but not sure whether it is possible, because of I borrowed a few pieces of code from erlang.jsf and python.jsf. What do you think?

I'm new to Elixir (but admire this language), so I hope to improve some aspects of this JSF in the future.

@cmur2
Copy link
Owner

cmur2 commented Jan 8, 2015

@Avil since python.jsf is originally from JOE it's under GPLv2 already and since I created erlang.jsf and submitted it to GPLv2 as well here, there should be no problem regardless how big the chunks or ideas were that you borrowed. I've no problem with this, since those are meant for learning too.

Maybe you can add a short sentence to the pull request and/or a short notice in the file about GPLv2.

And @utoddl is absolutely right!

@avli
Copy link
Contributor Author

avli commented Jan 8, 2015

@cmur2 Sounds good then. I don't mind if elixir.jsf will be licensed under GPLv2. I think, you can add a note about it in README.md as you already did for some syntax files. So, yes, it's under the GPLv2.

cmur2 pushed a commit that referenced this pull request Jan 8, 2015
Add Elixir syntax highlighting

Author provided this new file under GPLv2 as stated here: #18 (comment)
@cmur2 cmur2 merged commit 5e03e37 into cmur2:master Jan 8, 2015
@avli avli deleted the elixir-syntax-rc branch January 8, 2015 15:27
lpereira added a commit to lpereira/joe-editor that referenced this pull request Jan 11, 2015
All files were obtained from https://github.com/cmur2/joe-syntax.
Excerpt from its README.md listing credits and licensing information:

Every .jsf file from the original repository is under GPL2 as [JOE](http://sourceforge.net/projects/joe-editor/).

Every .jsf file created and modified exclusively by [cmur2](https://github.com/cmur2) is under GPL2 as [JOE](http://sourceforge.net/projects/joe-editor/).

Files with unknown license info:

* [elixir.jsf](https://github.com/cmur2/joe-syntax/blob/master/elixir.jsf) which is created by [Andrew Lisin](https://github.com/avli) under GPL v2 ([comment](cmur2/joe-syntax#18 (comment)))
* [erlang.jsf](https://github.com/cmur2/joe-syntax/blob/master/go.jsf) which is created by [Christian Nicolai](https://github.com/cmur2) and then modified by Jonas Rosling and enhanced with a small tweak from [raev](https://github.com/raev)
* [go.jsf](https://github.com/cmur2/joe-syntax/blob/master/go.jsf) which is entirely contributed by [Daniel Vargas](https://github.com/danielvargas)
* [js.jsf](https://github.com/cmur2/joe-syntax/blob/master/js.jsf) which is created by [Christian Nicolai](https://github.com/cmur2) and then modified by [Rebecca Turner](https://github.com/iarna)
* [json.jsf](https://github.com/cmur2/joe-syntax/blob/master/json.jsf) which is entirely contributed by [Rebecca Turner](https://github.com/iarna)
* [lsl.jsf](https://github.com/cmur2/joe-syntax/blob/master/lsl.jsf) which is from [Zai Lynch](https://wiki.secondlife.com/wiki/User:Zai_Lynch) under GPL v1 (delivered by [Rebecca Turner](https://github.com/iarna))
* [md.jsf](https://github.com/cmur2/joe-syntax/blob/master/md.jsf) which is created by [Christian Nicolai](https://github.com/cmur2) and then modified by Jonas Rosling
* [powershell.jsf](https://github.com/cmur2/joe-syntax/blob/master/powershell.jsf) which is entirely contributed by [Oskar Liljeblad](https://github.com/osklil)
* [puppet.jsf](https://github.com/cmur2/joe-syntax/blob/master/puppet.jsf) which is created by [Christian Nicolai](https://github.com/cmur2) and then modified by [Eric Eisenhart](https://github.com/eeisenhart)
* [sql.jsf](https://github.com/cmur2/joe-syntax/blob/master/sql.jsf) which is from an "unknown source" (delivered by [Rebecca Turner](https://github.com/iarna))
@cmur2
Copy link
Owner

cmur2 commented Mar 10, 2015

Hey, sorry to bother you again with this licensing stuff - recent discussions with the original project showed that it would be nice to have a "GPL v2 or any later version" license statement to be prepared for future developments. I already updated this for myself in the README and wanted to ask kindly if you are willing to declare your contents as "GPL v2 or any later version"?

@avli
Copy link
Contributor Author

avli commented Mar 10, 2015

Sure. Any content pulled by me to this repository as well as in my fork of this repository is GPL v2 or any later version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants