-
Notifications
You must be signed in to change notification settings - Fork 7
Upgrade to node v18 #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to node v18 #959
Conversation
✅ Deploy Preview for cmu-delphi-main ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bumps [hugo-bin](https://github.com/fenneclab/hugo-bin) from 0.119.0 to 0.122.3. - [Release notes](https://github.com/fenneclab/hugo-bin/releases) - [Commits](fenneclab/hugo-bin@v0.119.0...v0.122.3) --- updated-dependencies: - dependency-name: hugo-bin dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
|
This was still broken after my initial commit -- it looks like the fatal error was actually: and dependabot fixed this file sync problem as part of #960 , which i just merged into here and got a successful build. This PR should still fix the WARNINGS that i saw, which were numerous but looked like: |
|
this last commit updates node in the netlify environment, to match what github is now using in its actions: |
korlaxxalrok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍

The update to COVIDcast v3.2.10 in #957 broke the build when i merged it in... I think this is because it introduced some dependencies that require node version 18+ (search https://github.com/cmu-delphi/www-main/blob/9bf7a77e17121279727046fb442e66891d6f25d8/package-lock.json for
node": ">=18to find them). Hopefully this appeases the build process....