Skip to content

Conversation

@melange396
Copy link
Contributor

The update to COVIDcast v3.2.10 in #957 broke the build when i merged it in... I think this is because it introduced some dependencies that require node version 18+ (search https://github.com/cmu-delphi/www-main/blob/9bf7a77e17121279727046fb442e66891d6f25d8/package-lock.json for node": ">=18 to find them). Hopefully this appeases the build process....

@netlify
Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for cmu-delphi-main ready!

Name Link
🔨 Latest commit e0e56ab
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-main/deploys/662815890993c200081eb9eb
😎 Deploy Preview https://deploy-preview-959--cmu-delphi-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Bumps [hugo-bin](https://github.com/fenneclab/hugo-bin) from 0.119.0 to 0.122.3.
- [Release notes](https://github.com/fenneclab/hugo-bin/releases)
- [Commits](fenneclab/hugo-bin@v0.119.0...v0.122.3)

---
updated-dependencies:
- dependency-name: hugo-bin
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@melange396
Copy link
Contributor Author

This was still broken after my initial commit -- it looks like the fatal error was actually:

npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! 
npm ERR! Invalid: lock file's [email protected] does not satisfy [email protected]

and dependabot fixed this file sync problem as part of #960 , which i just merged into here and got a successful build. This PR should still fix the WARNINGS that i saw, which were numerous but looked like:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v1[6](https://github.com/cmu-delphi/www-main/actions/runs/8806124386/job/24170226118#step:5:7).20.2', npm: '8.19.4' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'string-width@[7](https://github.com/cmu-delphi/www-main/actions/runs/8806124386/job/24170226118#step:5:8).1.0',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '[8](https://github.com/cmu-delphi/www-main/actions/runs/8806124386/job/24170226118#step:5:9).19.4' }
npm WARN EBADENGINE }
...

@melange396
Copy link
Contributor Author

this last commit updates node in the netlify environment, to match what github is now using in its actions:
image
and it also updates the npm version to match github actions, as well as the hugo version to match #944

@melange396 melange396 requested a review from korlaxxalrok April 23, 2024 20:19
Copy link
Contributor

@korlaxxalrok korlaxxalrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants