Skip to content

Conversation

@ryantibs
Copy link
Member

@ryantibs ryantibs commented Jan 5, 2022

Update to the "About COVIDcast" page. This is a work in progress.

@netlify
Copy link

netlify bot commented Jan 5, 2022

✔️ Deploy Preview for cmu-delphi-main ready!

🔨 Explore the source changes: d443486

🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-main/deploys/61d7962ab56de3000755659c

😎 Browse the preview: https://deploy-preview-542--cmu-delphi-main.netlify.app/covid19

@ryantibs ryantibs marked this pull request as ready for review January 5, 2022 14:27
@ryantibs
Copy link
Member Author

ryantibs commented Jan 5, 2022

While I'm here, I decided to also shorten the main "About" page, since it now contains some overlap with the "About COVIDcast" page.

This is now ready for review. @capnrefsmmat @krivard Please take a look. This will close #482.

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple minor suggestions.

Also, should the About COVIDcast page use the same nice layout as the About Delphi page?

@ryantibs
Copy link
Member Author

ryantibs commented Jan 7, 2022

Thanks for the review. I committed your suggestions.

Re layout: maybe; but the "About Delphi" page appears to be special and most other pages appear to have the same layout as "About COVIDcast" (include "About CTIS"). So I'm fine proceeding as is for now.

p.s. I snuck in a commit to remove a duplicate CTIS entry in the research page. I used my favored "short title" 🙂 the first time I put it up, as a medRXiv paper, and then when Christy updated the page to have the PNAS links, she must have created a new one, not realizing it was the same paper.

@ryantibs ryantibs removed the request for review from krivard January 7, 2022 13:24
@ryantibs
Copy link
Member Author

ryantibs commented Jan 7, 2022

@capnrefsmmat Please approve at your convenience!

@ryantibs ryantibs merged commit 502537d into dev Jan 7, 2022
@ryantibs ryantibs deleted the ryan/about-covidcast branch January 7, 2022 21:47
This was referenced Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants