-
Notifications
You must be signed in to change notification settings - Fork 7
About COVIDcast update #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for cmu-delphi-main ready! 🔨 Explore the source changes: d443486 🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-main/deploys/61d7962ab56de3000755659c 😎 Browse the preview: https://deploy-preview-542--cmu-delphi-main.netlify.app/covid19 |
|
While I'm here, I decided to also shorten the main "About" page, since it now contains some overlap with the "About COVIDcast" page. This is now ready for review. @capnrefsmmat @krivard Please take a look. This will close #482. |
capnrefsmmat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple minor suggestions.
Also, should the About COVIDcast page use the same nice layout as the About Delphi page?
Co-authored-by: Alex Reinhart <[email protected]>
Co-authored-by: Alex Reinhart <[email protected]>
|
Thanks for the review. I committed your suggestions. Re layout: maybe; but the "About Delphi" page appears to be special and most other pages appear to have the same layout as "About COVIDcast" (include "About CTIS"). So I'm fine proceeding as is for now. p.s. I snuck in a commit to remove a duplicate CTIS entry in the research page. I used my favored "short title" 🙂 the first time I put it up, as a medRXiv paper, and then when Christy updated the page to have the PNAS links, she must have created a new one, not realizing it was the same paper. |
|
@capnrefsmmat Please approve at your convenience! |
Update to the "About COVIDcast" page. This is a work in progress.