Skip to content

Conversation

@christymelucci
Copy link
Contributor

@christymelucci christymelucci commented Dec 6, 2021

Fixes #519

@netlify
Copy link

netlify bot commented Dec 6, 2021

✔️ Deploy Preview for cmu-delphi-main ready!

🔨 Explore the source changes: 6c3a8f6

🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-main/deploys/61adbc70c5a5c50007eb4c86

😎 Browse the preview: https://deploy-preview-520--cmu-delphi-main.netlify.app

@christymelucci
Copy link
Contributor Author

@ryantibs or @RoniRos Please review this Draft PR

@christymelucci christymelucci changed the title Create 2021_11_22_nyt.md Add Nov. 22, 2021, New York Times article Dec 6, 2021
@christymelucci christymelucci changed the title Add Nov. 22, 2021, New York Times article Add Nov 2021 New York Times article to news page Dec 6, 2021
@ryantibs
Copy link
Member

ryantibs commented Dec 6, 2021

The news item looks good to me!

One very minor thought about the thumbnails used on the front page news wheel: the "D" logo looks a little plain, especially as it does when it gets used twice in visible set of three. (Screenshot below):

Screen Shot 2021-12-06 at 10 54 09 AM

Maybe we can get into a habit of using a screenshot of a graphic in the news article as its thumbnail?

This is not a blocker for me to merge this PR, so I'm just going to go and already approve it, but if it's easy enough to try then feel free to give it a shot.

@ryantibs ryantibs marked this pull request as ready for review December 6, 2021 15:56
@christymelucci
Copy link
Contributor Author

christymelucci commented Dec 6, 2021

  • Today, I will see if we can add screenshot of graphic in the news article as a thumbnail (assuming there is not a concern for image rights), plus add an image for the ASA award news post.
  • On Fri, I will check to see see if this step regarding image can be added to instructions for posting new news items: https://github.com/cmu-delphi/www-main#adding-new-news-item

@christymelucci
Copy link
Contributor Author

@krivard,

  • I am looking at Ryan's request to add an image to a news card in the Latest News section at the bottom of the home page.
  • After reviewing this page, I am not certain if his request can be fulfilled in the current configuration as it appears that the latest-news-item card always/only looks for the the "D" logo /images/placeholder-thumb.jpg (although this is not the case for the latest-blog card).
  • Can you confirm if it is correct that an alternate image cannot be added at the moment? If so, is it a feature that is simple to add?

@krivard
Copy link
Contributor

krivard commented Dec 6, 2021

@christymelucci that is correct -- we don't currently use thumbnails for news items. Adding thumbnails for news items could be pursued at a couple different levels of complexity, but they're all out of scope for this PR.

I've created a new issue with the details.

@christymelucci christymelucci removed the request for review from RoniRos December 7, 2021 03:47
@christymelucci
Copy link
Contributor Author

Merging "as is" to ensure timely post. Image improvements for news articles to be addressed shortly.

@christymelucci christymelucci merged commit 70536cc into dev Dec 7, 2021
@christymelucci christymelucci deleted the cmelucci/nyt-article branch December 7, 2021 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update news page

4 participants