-
Notifications
You must be signed in to change notification settings - Fork 7
Add Nov 2021 New York Times article to news page #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for cmu-delphi-main ready! 🔨 Explore the source changes: 6c3a8f6 🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-main/deploys/61adbc70c5a5c50007eb4c86 😎 Browse the preview: https://deploy-preview-520--cmu-delphi-main.netlify.app |
|
The news item looks good to me! One very minor thought about the thumbnails used on the front page news wheel: the "D" logo looks a little plain, especially as it does when it gets used twice in visible set of three. (Screenshot below): Maybe we can get into a habit of using a screenshot of a graphic in the news article as its thumbnail? This is not a blocker for me to merge this PR, so I'm just going to go and already approve it, but if it's easy enough to try then feel free to give it a shot. |
|
|
|
@christymelucci that is correct -- we don't currently use thumbnails for news items. Adding thumbnails for news items could be pursued at a couple different levels of complexity, but they're all out of scope for this PR. |
|
Merging "as is" to ensure timely post. Image improvements for news articles to be addressed shortly. |

Fixes #519