Skip to content

Update indicators paper; add perspective piece #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 19, 2021
Merged

Update indicators paper; add perspective piece #504

merged 20 commits into from
Nov 19, 2021

Conversation

@christymelucci
Copy link
Contributor

@christymelucci christymelucci commented Nov 17, 2021 •
edited by krivard
Loading

Add ‘indicators-hero.jpg’ (1440x500)

Fixes #464

@netlify
Copy link

netlify bot commented Nov 17, 2021 •
edited
Loading

✔️ Deploy Preview for cmu-delphi-main ready!

🔨 Explore the source changes: 1e859ae

🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-main/deploys/6196b62ba329720008fe75ce

😎 Browse the preview: https://deploy-preview-504--cmu-delphi-main.netlify.app

@christymelucci christymelucci changed the title Add files via upload Add indicators paper hero image Nov 17, 2021
@christymelucci
Delete indicators-hero.jpg
7487946 
Delete to replace with higher res image
@christymelucci
Add files via upload
0670852 
Add hero image for indicators paper on research page
@christymelucci
Delete indicators-hero.jpg
a21dbe8
@christymelucci
Add files via upload
22689ef
@christymelucci
Update _index.md
2e31b75 
Add correct hero image for indicators paper
@christymelucci
Copy link
Contributor Author

christymelucci commented Nov 18, 2021

Added hero image for indicators paper, then pointed hero to image

@christymelucci
Update index.md
49c4e20 
Add Google Fellows to authors on indicators paper
@christymelucci
Copy link
Contributor Author

christymelucci commented Nov 18, 2021

Updated the indicators paper author list to include the Google Fellows

@christymelucci
Update index.md
874c121 
Remove 2 first names in indicators paper author list
@christymelucci christymelucci changed the title Add indicators paper hero image Update indicators paper her image and authors, plus add perspective piece by Roni and Ryan Nov 18, 2021
@christymelucci christymelucci changed the title Update indicators paper her image and authors, plus add perspective piece by Roni and Ryan Update indicators paper image and authors; add perspective piece by Roni and Ryan Nov 18, 2021
@christymelucci christymelucci changed the title Update indicators paper image and authors; add perspective piece by Roni and Ryan Update indicators paper image and authors Nov 18, 2021
krivard
krivard reviewed Nov 18, 2021
View reviewed changes
@christymelucci
Update author list for indicators article
998a34a 
Remove Elena's first name in author list for indicators article
@christymelucci christymelucci marked this pull request as ready for review November 18, 2021 15:07
@christymelucci
Copy link
Contributor Author

christymelucci commented Nov 18, 2021

Will update this branch to use it to add the perspective paper to the research page (and to the carousel if Ryan indicates he would like it there too).

@christymelucci christymelucci changed the title Update indicators paper image and authors Update indicators paper; add perspective piece Nov 18, 2021
@christymelucci
Add perspective piece; update casual paper
cbc3db2 
Add perspective piece (w/ temp image); update journal info for “Causal Inference in the Time of COVID-19” paper
@christymelucci
check temp image error
84b62f1
@christymelucci
add temp image for perspective piece
401d8b2
@christymelucci
Update index.md
7cb615d
@christymelucci christymelucci marked this pull request as draft November 18, 2021 17:15
@krivard
Copy link
Contributor

krivard commented Nov 18, 2021

Wow that's still applying really terrible jpeg compression, trying a different crop

@krivard
Copy link
Contributor

krivard commented Nov 18, 2021

okay that's less bad

@christymelucci
Copy link
Contributor Author

christymelucci commented Nov 18, 2021

Adding new perspective image related to "The Road Ahead" close in the perspective piece.
Check: Does this image take the balance over the top in the nature category for the research page? If leaning toward 'yes', is it reasonable to keep it (for research page + add hero version) for now so the piece posts, then update later if a more compelling image can be found?

krivard
krivard approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nature images are compelling; I don't think we need to worry about overdoing them

@christymelucci christymelucci marked this pull request as ready for review November 18, 2021 21:44
@krivard krivard merged commit 2051ff7 into dev Nov 19, 2021
@krivard krivard deleted the christy-research-indicators-update branch November 19, 2021 18:57
@krivard krivard mentioned this pull request Nov 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krivard krivard Awaiting requested review from krivard

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Correct hero image for indicators paper

3 participants

@christymelucci @krivard