Skip to content

Conversation

@sgratzl
Copy link
Member

@sgratzl sgratzl commented Jun 7, 2021

closes #367

improves the webp generation

@sgratzl sgratzl added the bug label Jun 7, 2021
@sgratzl sgratzl self-assigned this Jun 7, 2021
@sgratzl sgratzl requested a review from krivard June 7, 2021 17:52
@netlify
Copy link

netlify bot commented Jun 7, 2021

✔️ Deploy Preview for cmu-delphi-main ready!

🔨 Explore the source changes: beb2a15

🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-main/deploys/60bf20d86305cb0007e9ad0e

😎 Browse the preview: https://deploy-preview-371--cmu-delphi-main.netlify.app

@krivard krivard requested a review from ryantibs June 7, 2021 18:16
@krivard
Copy link
Contributor

krivard commented Jun 7, 2021

tagging Ryan, since I've been looking at this for too long and can't tell the difference any more 😕

@ryantibs
Copy link
Member

ryantibs commented Jun 7, 2021

Still looks the same as before (thumbnails are just as blurry) to me. E.g., first one: screenshot of thumbnail. Second one: screenshot of full pic.

Screen Shot 2021-06-07 at 3 30 12 PM

Screen Shot 2021-06-07 at 3 32 19 PM

This is not a big deal, so if it isn't easily fixable without a lot of cycles, I'd say don't worry about it!

@sgratzl
Copy link
Member Author

sgratzl commented Jun 8, 2021

I just changed the thumbnails to have a higher resolution that better fits the layout. So far the had a height of 200 pixels but most of them were rendered with a height of 300px causing upscaling artifacts. Now the thumbnails have a size of 300x300 pixels which should work better in both desktop and mobile layouts

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgratzl sgratzl merged commit 570428a into dev Jun 8, 2021
@sgratzl sgratzl deleted the sgratzl/imagewebp branch June 8, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pixelated blog preview pictures

4 participants